Skip to content

Edit comment in php block of the admonition note related to escape @ and % #12540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Edit comment in php block of the admonition note related to escape @ and % #12540

merged 1 commit into from
Oct 24, 2019

Conversation

abdellatif05
Copy link
Contributor

In the php block of the admonition note related to escape @ and % :
comments should be related to PHP and not related to XML

@javiereguiluz javiereguiluz added this to the 3.4 milestone Oct 24, 2019
@OskarStark
Copy link
Contributor

Thanks for fixing this bug Abdellatif.

OskarStark added a commit that referenced this pull request Oct 24, 2019
…o escape @ and % (abdellatif05)

This PR was merged into the 3.4 branch.

Discussion
----------

Edit comment in php block of the admonition note related to escape @ and %

In the php block of the admonition note related to escape **@** and **%**  :
comments should be related to PHP and not related to XML

Commits
-------

f7c20b5 Edit comment
@OskarStark OskarStark merged commit f7c20b5 into symfony:3.4 Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants